search

broadinstitute / oncotator

Other
67 stars 33 forks source link

Malformed VCFs don't generate an error message. #354

Open alanhoyle opened 8 years ago

alanhoyle commented 8 years ago

We have some VCF-like files which had some INFO and FORMAT headers omitted. When Oncotator runs on these, it drops any of the data associated with those missing headers, but, as near as I can tell, does this silently. It's not until after the oncotator has finished and we try to look into the VCFs that we notice that it's missing the information we're looking for.

alanhoyle commented 6 years ago

Other than fixing the headers in VCF, is there any way to just tell oncotator to just let the data pass through into the output?

LeeTL1220 commented 6 years ago

Not easily, we did make a design decision that Oncotator did not have to honor fields that were not in the VCF header. Under the hood, handling arbitrary fields was surprisingly difficult for internal consistency -- especially for those using Oncotator to convert between VCF and MAF.

On Fri, Jan 26, 2018 at 2:30 PM, Alan Hoyle notifications@github.com wrote:

Other than fixing the headers in VCF, is there any way to just tell oncotator to just let the data pass through into the output?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/broadinstitute/oncotator/issues/354#issuecomment-360881869, or mute the thread https://github.com/notifications/unsubscribe-auth/ACDXk06GykU1ZdfgZjXcJ8N3x-nlkcfhks5tOifugaJpZM4Jwz-x .

-- Lee Lichtenstein Broad Institute 75 Ames Street, Room 8011A Cambridge, MA 02142 617 714 8632