search

broadinstitute / pooled-cell-painting-profiling-recipe

:woman_cook: Recipe repository for image-based profiling of Pooled Cell Painting experiments
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Handle empty files #22

Closed ErinWeisbart closed 4 years ago

ErinWeisbart commented 4 years ago

Allows processing to handle situation where some objects were not detected in a site.

gwaybio commented 4 years ago

Looks like we're seeing some duplicate commits creep in. This is fine - we just need to make sure that when we're creating new branches, we are creating them from up-to-date synced masters

ErinWeisbart commented 4 years ago

This shouldn't have the Merge... commit b8a0ed4 but I can't figure out how to get rid of it...

gwaybio commented 4 years ago

short of deleting history (eek!) it cannot be removed. The branch was created from an older master and then not properly synced after the other was merged. Its nbd and breaks nothing.

In the future, making sure new branches are created from an up-to-date master (git fetch upstream; git merge upstream/master; git push) will prevent this. It happens all the time, especially when we're pushing.

LMK when ready for review

ErinWeisbart commented 4 years ago

Drats. Ready for review.