broadinstitute / pooled-cell-painting-profiling-recipe

:woman_cook: Recipe repository for image-based profiling of Pooled Cell Painting experiments
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

First refactor effort on march to first release version 0.1 #34

Closed gwaybio closed 4 years ago

gwaybio commented 4 years ago

This PR mostly touches the preprocessing module. The PR also introduces minor changes in two files in the generate profiles module: 1.generate-profiles/profiling_config.yaml and 1.generate-profiles/0.merge-single-cells.py

Changelog

gwaybio commented 4 years ago

Thanks for the review - sorry it took me so long to revisit

Readme formatting

See my clarification above.

Do we include both command line and config force_overwrite? (Discussed here)

Yep, we do. See https://github.com/broadinstitute/pooled-cell-painting-profiling-recipe/pull/34/files#diff-6cb5ff5c1a4737e846595bbb4e05719fR11. We can revisit this decision too, once we get some time to play with the welding

You said this PR only touches preprocessing module, but there are commits that touch 1.generate-profiles/profiling_config.yaml and 1.generate-profiles/0.merge-single-cells.py. Do you want to revert them and move them to a different PR?

Nice catch. Can't sneak anything by! Since it is not doing any harm, how about I edit the note in the initial description, and then we can go ahead and merge?

ErinWeisbart commented 4 years ago

LGTM!