search

broadinstitute / pooled-cell-painting-profiling-recipe

:woman_cook: Recipe repository for image-based profiling of Pooled Cell Painting experiments
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Cleaning up spot outputs #37

Closed gwaybio closed 4 years ago

gwaybio commented 4 years ago

closes #19

gwaybio commented 4 years ago

LGTM at a read through. (Lemme know if you want me to dig deep and I'll run it on my own, but I trust it does what you say it does)

This is a perfect review btw, it is super for us to describe exactly how we reviewed.

From this post 👇 

Reviewers
Guards the commit history.

Are NOT responsible to test the code.

Should response within a logical time, or ping the reviewee to opt out of the review

The review process
Read the pull request title and body to see that you get the need and value of the pull quickly.

Validate sane git commits.

Validate CI checks are passing.

NEVER REVIEW CODE BEFORE THIS IS DONE
Actually reviewing code
Review commit by commit to get the story of the change.

Always comment on lines in diff view, not in general discussion at the pull request page.

Nitbitting VS Bikeshedding 1/2
Comment on all that gets your attention, including typos, However, Don’t lose sight on what the pull requests actual value.

Ask in a polite way if you need elaboration.

Use Emoji!!1.

Since we don't have tests (yet), and the project is still very new, it is up to the developer to ensure that the code actually works

ErinWeisbart commented 4 years ago

Also from that post: NEVER EVERZ APPROVE WITHOUT APPROPRIATE GIF So in that spirit: