search

broadinstitute / pooled-cell-painting-profiling-recipe

:woman_cook: Recipe repository for image-based profiling of Pooled Cell Painting experiments
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Updating Prefilter to accept no flags #4

Closed gwaybio closed 4 years ago

gwaybio commented 4 years ago

Previously, when no flags were included prefilter would throw an error and not complete. This PR fixes this behavior.

I also add in Resize as a flagged feature and other minor updates.

gwaybio commented 4 years ago

in this project, as long as it is just you and I contributing let's have the person who opened the PR initiate the merge.

The reviewer's job is to review the code, request changes, and initiate conversations about specific changes. These conversations can be anything including curiosity-driven comments and comments suggesting specific changes. Once the reviewer is satisfied, then they will approve the PR. Once approved, the person who opened it will merge.

In general, there may be things that the pull request opener (you or I) will want to incorporate before actually merging. In this case, if after review, the reviewer will need to quickly look at the updated commits. This is uncommon but it actually happened yesterday (see https://github.com/broadinstitute/lincs-cell-painting/pull/24#issuecomment-624246696).

If the updates introduced in the pull request are crucial to progress and are blocking for some reason, then let's keep lines of communication open. "Hey Greg, merge your dang code already I need it for my own stuff!" is perfectly reasonable and encouraged to speed progress.

There are a bunch of exceptions to this rule - when in doubt just act (like you did) and everything will work out.

cc @ErinWeisbart

p.s. - I was planning on creating simple CONTRIBUTING.md file, which will outline these soft guidelines.

ErinWeisbart commented 4 years ago

Sorry! I think I understand what to do going forward.