search

broadinstitute / pooled-cell-painting-profiling-recipe

:woman_cook: Recipe repository for image-based profiling of Pooled Cell Painting experiments
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Updating paths before first weld #43

Closed gwaybio closed 4 years ago

gwaybio commented 4 years ago

The recipe will be called as a submodule in the template repo. This pull request ensures that a call to bash weld.sh will call the versioned controlled recipe scripts.

An important note here is that after this is merged, testing with the recipe as we have in the past will no longer work.

A second important note is that the config_utils.py file will eventually be moved to the template (this way all the config related files are kept in one place). This is the current thinking right now at least.

gwaybio commented 4 years ago

Awesome - agree with your suggestion (see #46 )

An important note here is that after this is merged, testing with the recipe as we have in the past will no longer work.

We really need to get some testing done in this repo 😖

I am thinking that I can address #45 here, if we can solve it quickly (should be a super quick fix once we settle on nomenclature)

gwaybio commented 4 years ago

Prepare for a landmark pull request merge! This PR represents the bulk of the remaining fixes to welding version 0.1 🎉

ErinWeisbart commented 4 years ago