search

broadinstitute / pooled-cell-painting-profiling-recipe

:woman_cook: Recipe repository for image-based profiling of Pooled Cell Painting experiments
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Codify new contribution protocol #82

Closed ErinWeisbart closed 9 months ago

ErinWeisbart commented 2 years ago

Now that Greg has left the Imaging Platform (😢) and started his own lab (😄), we need to figure out how to handle contributions/changes/updates (i.e. PRs) to the Recipe (and Template).

I'm taking over internal ownership of the repos, but we need to codify how PRs are handled now. To that end, @gwaygenomics we need to know how much you would still like to be involved in these repos. I see three options, though feel free to add nuance or suggest a different breakdown:

1) Greg has the time and desire to be involved to the same level as before leaving - reviewing every PR in a timely manner. 2) Greg has some time to give and will review major PRs that touch a lot of code or change something fundamental about the recipe, but doesn't have time to give to the little stuff. 3) Greg will keep an eye on the repo as he has time and might chime in if tagged, but is too busy to commit to any guaranteed level of involvement in the repos.

gwaybio commented 2 years ago

My vote is for 3 :)

I think the project should not wait for me on anything

ErinWeisbart commented 2 years ago

Thanks @gwaygenomics !

@shntnu does this mean you are my go-to for help reviewing larger PRs? Or would that be @bethac07? Or...?

shntnu commented 2 years ago

@shntnu does this mean you are my go-to for help reviewing larger PRs?

I'm definitely the least knowledgeable here about this workflow. I'd favor @MerajRamezani over me

Or would that be @bethac07?

Over to Beth to decide how she'd like to be involved with this process

bethac07 commented 2 years ago

I'm happy to be tagged but if it's hardcore profiling stuff it might be nice to get @shntnu 's input from time to time too :)

shntnu commented 2 years ago

Certainly!

So if Meraj does not object, then Erin should tag Meraj for the review, who might then bump it to Beth. I can be tagged at any point where I am required. Greg can join in at any point and we can @ him on topics that might be of interest to him, but we will not wait for him on anything (per his preference)

Does that sound good to everyone?

Of course, I'm hoping that over time, there will be a lot more contributors; this is to get us started.

MerajRamezani commented 2 years ago

Sounds good to me and I would be happy to participate. I can bump it to Beth/Greg/Shantanu in case someone's expertise is required.

ErinWeisbart commented 2 years ago

Thanks y'all!

shntnu commented 2 years ago

Wonderful @MerajRamezani !