Closed mtomko closed 9 months ago
Personally, if I were going to switch to then
in if-then-else's, I wouldn't also use curly braces. I'd go completely new-style or stay completely old-style wrt this. I find the mixture to be a bit discombobulating.
OTOH, I have no interest in being a style nazi either.
:cat: :moon: 🎱
I just run the compiler through with the first set of options described here:
Namely, -new-syntax -rewrite
. I manually replaced imports ending with ._
with .*
, too.
Because Scala 3's syntactic changes are so new, I decided not to go to the indentation significant route yet. if-then-else
plus for-do
etc has the advantage (in my opinion) of having fewer parens, which offers some moderate value.
I may well go the route of significant indentation here at some point, though. If people feel like PoolQ should go whole hog, I'm happy to run the next set of compiler syntax rewrites. Perhaps I'll do that anyway and provide it as a commit at the end here, which we could decide to keep or drop.
I just run the compiler through with the first set of options described here:
fyi: https://scalameta.org/scalafmt/docs/configuration.html#rewritescala3converttonewsyntax
Closing in favor of https://github.com/broadinstitute/poolq/pull/34
https://github.com/broadinstitute/poolq/issues/5