search

broadinstitute / profiling-resistance-mechanisms

Predicting pharmacodynamic responses to cancer drugs using cell morphology
BSD 3-Clause "New" or "Revised" License
7 stars 5 forks source link

Adding files relevant to figure generation #125

Closed mekelley closed 1 year ago

mekelley commented 1 year ago

Adding files (prism, matlab, md) relevant to figure generation

gwaybio commented 1 year ago

@mekelley - just a quick note that we should work towards merging this PR into the repository. Do you need help with this?

mekelley commented 1 year ago

Yes! Sorry, I didn't realize I left this hanging. Guidance on how to proceed?

gwaybio commented 1 year ago

Guidance on how to proceed?

Yep! Please see each comment in this PR and address them one by one. If you need specific guidance on these steps, please do not hesitate to ask.

mekelley commented 1 year ago

It looks like the last three commits I pushed addressed all the comments, not sure what the next step is

gwaybio commented 1 year ago

Oh gotcha, yes, this was not clear. Please add comments to each discussion describing how the commit addresses the comment.

gwaybio commented 1 year ago

Thanks @mekelley ! This is looking good. I have one last comment https://github.com/broadinstitute/profiling-resistance-mechanisms/pull/125#discussion_r1257510415

mekelley commented 1 year ago

Hi Greg,

I'm sorry but I have no idea how to make the changes you're requesting here. I'm sure it's straightforward but I just don't have familiarity with GitHub. Could you either make the change or provide step by step instructions for how to do so?

-Megan

Megan Elizabeth Kelley, PhD Laboratory of Chemistry and Cell Biology The Rockefeller University On Jul 9, 2023 at 12:34 PM -0400, Gregory Way @.***>, wrote:

Thanks @mekelley ! This is looking good. I have one last comment #125 (comment) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

gwaybio commented 1 year ago

on it. WIll merge after I address these files.

(I was initially confirming if the six data files changed here were changed for a reason, but it seems the answer is no and that we can revert them 😄 )

gwaybio commented 1 year ago

ooooh, I think i see what happened. You're converting the git lfs compressed .tsv files into .csv files and adding these data here.

I will delete these .csv files to reduce repo bloat (no need to have them here), then we should be good to go!

gwaybio commented 1 year ago

congrats on your code contribution @mekelley !! Merging now