broadinstitute / puppet-certs

SSL Certificate File Management for Puppet
BSD 3-Clause "New" or "Revised" License
4 stars 6 forks source link

Outdated depencency puppetlabs/concat blocks upgrading #30

Closed llauren closed 6 years ago

llauren commented 6 years ago

Hi!

The Certs module requires a puppetlabs/concat module of version less than 3. Any chance of bumping this up to a current concat (now 4.2.1)?

I could force-upgrade, but that feels rather brutish... and anything i break is then mine to fix :)

Problem: https://github.com/broadinstitute/puppet-certs/blob/92544b7d8480e1c26a95bb7fc59ee8ea8ea19f62/metadata.json#L65

Suggested fix:

    { "name":"puppetlabs/concat","version_requirement":">= 1.1.1 < 5.0.0" }

Thanks, ~rL

rcalixte commented 6 years ago

@llauren thanks for the notice, this will get merged into a new release soon

rcalixte commented 6 years ago

@llauren this should be fixed in 2.2.1. Thanks for the issue!