Open joicy opened 2 years ago
dpark01
commented
2 years ago Really ideal would be to use this data source which is pre-ETLed, cleaned up, easy to digest, and updated daily. Already comes with masked alignments and such. Folks use this routinely for tree building on global data sets.
Also a bonus: it’s in the exact same format as what GISAID data would look like if you used nextstrain’s ETL scripts on it.
fritzo
commented
2 years ago Hi @joicy, the easiest way to start work on this feature would be to update scripts/preprocess_gisaid.py and scripts/preprocess_nextclade.py to read from files other than results/gisaid.json. The least amount of code change would involve creating files in the gisaid.json format: a newline-delimited list of json dictionaries that look like:
{"covv_virus_name": ..., "covv_accession_id": ..., "covv_collection_date": ..., "covv_location": ..., "covv_add_location": ..., "covv_lineage": ..., "sequence": ...}If instead you want to more natively support another format, you could replace scripts/preprocess_gisaid.py with some other say scripts/preprocess_ncov.py and make slight modifications to scripts/preprocess_nextclade.py.
The two intermediate files that are constructed from gisaid data are
results/columns.pkl which is a column-oriented dict-of-lists, with columns like day and lineage (but beware this code is moving around quickly and the columns have been changing a lot, see code for source of truth).results/aligndb is a place to cache results of alignment and running usher/panglin to classify lineages. This is populated by preprocess_nextclade.py which only needs the sequence and covv_accession_id fields.Re: contributing, I'm happy to review PRs and help with writing unit tests and answer questions about code.
joicy
commented
2 years ago Hi @fritzo, thank you for explaining to me. We just receive the application form to data feed on GISAID, so maybe won't be necessary. However, I would like to try these changes in parallel. Could you provide me with a results/gisaid.json example file?
joicy
commented
2 years ago Really ideal would be to use this data source which is pre-ETLed, cleaned up, easy to digest, and updated daily. Already comes with masked alignments and such. Folks use this routinely for tree building on global data sets.
Also a bonus: it’s in the exact same format as what GISAID data would look like if you used nextstrain’s ETL scripts on it.
@dpark01 It is a really good resource, but our data is stored just by GISAID.
fritzo
commented
2 years ago Hi @joicy, realistically I won't have time to help out with this task until say January at earliest. We are focusing on just being able to run the model ourselves, after months of data drift changed model requirements (e.g. PANGO lineages are increasingly conflated, dates and locations are increasingly erroneous).
fritzo
commented
2 years ago @dpark01 can you provide any other links to the Nextstrain GenBank data feed you recommended? The docs are broken, so maybe I can follow one of your existing pipelines.
EDIT Aha, I see there are docs about remote inputs, which point to buckets on AWS and GCP:
dpark01
commented
2 years ago @fritzo sorry for the delayed response, but yes, you've found the public GCS bucket we use to mirror their S3 bucket. Files that you may find useful:
The regional build files (named by continents) are probably not of interest to you. The json-formatted metadata might be interesting, I haven't tried--I don't know if that's a more raw version of what NCBI Virus/BioSample provides than the metadata.tsv.
Our mirror syncs with their S3 bucket every morning (usually after their daily builds complete), and they tend to update their files every weekday from a continental Europe time zone.
A lot of our analyses (that desire really up-to-date global inputs) directly ingest from this bucket.
fritzo
commented
2 years ago Hi @joicy, we've revised our preprocessing pipeline to input an UShER tree using open GENBANK data, rather than a GISAID tree, so hopefully you should be able to run the model more easily. (We still support GISAID input but you would need to build your own UShER tree for that usage).
joicy
commented
2 years ago Hi @fritzo thank you for letting me know and for providing this feature. I'm gonna try to use it soon.
Hi there! I'm trying to set up Pyro-cov using GISAID but I don't have a data feed yet. It would be possible to use the pipeline with other data sources, like fasta files I have been downloaded? Would be a pleasure to contribute with new features.