search

broadinstitute / pyro-cov

Pyro models of SARS-CoV-2 variants
Apache License 2.0
77 stars 27 forks source link

Resolves #23 #53

Closed fritzo closed 1 year ago

fritzo commented 1 year ago

Resolves #23

Avoids vectorization to avoid tensor shape errors

fritzo commented 1 year ago

Looks like linting is failing due to the new file generate_epiToPublicAndDate.py. @bkotzen could you add that file to the flake8 ignores in setup.cfg so CI is unblocked?

bkotzen commented 1 year ago

sure thing! does it work now?

bkotzen commented 1 year ago

It seems to be clearing flake8 and getting hung on black now? Is there a different place for me to deal with that?

fritzo commented 1 year ago

Thanks @bkotzen. I ran make format to fix the black errors, then added some type: ignore stuff to fix the subsequent mypy errors.

fritzo commented 1 year ago

@bkotzen could you add me as a maintainer or contributor in repo settings, so I can (1) retry failed builds, (2) add tags to issues, (3) merge PRs?

fritzo commented 1 year ago

😅 phew this PR required a whole lot of maintenance fixes!

@bkotzen could you please take another look? Thanks!

bkotzen commented 1 year ago

Looks good to me, thanks for weeding through all this! I don't think I have access to repository settings; I can try to chase down who does if you would still like to be maintainer / contributor?