Closed ch-kr closed 1 year ago
Additional changes:
build_models
calls (removed trimers
arg)hl.qchisqtail
)P_VALUE
constantMIN_EXP_MIS
constant and set it to 16.0MIN_CHISQ_THRESHOLD
constantAdditional comments:
grouped_single_no_break_ht_path
in prepare_transcripts.py
doesn't have a freeze argument passed in - should we add this?rmc.py
in single_search_round_ht_path()
to return f"{single_search_bucket_path(search_num, freeze)}/{break_status}{breakpoint_status}.ht"
freeze
argument to merge_rmc_hts
and consequently merge_round_no_break_ht
since it uses single_search_round_ht_path
and simul_search_round_bucket_path
(currently with the default CURRENT_FREEZE
)Places where we need to add freeze to a temp filename:
regional_constraint.py
: f"{TEMP_PATH_WITH_FAST_DEL}/round{args.search_num}_temp.ht",
regional_constraint.py
: f"{TEMP_PATH_WITH_SLOW_DEL}/rmc_results.ht",
constraint.py
: f"{TEMP_PATH_WITH_FAST_DEL}/group_max_chisq.ht", overwrite=True
constraint.py
: f"{temp_path}/round{search_num}_all_loci_chisq.ht", overwrite=True
(if saved in TEMP_PATH_WITH_FAST_DEL
constraint.py
: f"{TEMP_PATH_WITH_FAST_DEL}/search_union.ht", overwrite=True
addressed comments above and also added:
Major changes:
Minor changes: