search

broadinstitute / regional_missense_constraint

Code to calculate regional missense constraint
BSD 3-Clause "New" or "Revised" License
12 stars 1 forks source link

Add mypy to pre-commit #270

Closed illusional closed 1 year ago

illusional commented 1 year ago

Feel free to close if not desired, but we find it handy internally to use mypy as it's better at catching type errors.

ch-kr commented 1 year ago

basic question, wouldn't we also need to add mypy to requirements-dev.in? (and isort)

illusional commented 1 year ago

The pre-commit library will keep everything installed and correct version itself (except pylint which I listed as local, because it works better with packages that way), so no need to add them explicitly to requirements-dev.

illusional commented 1 year ago

Just noting that mypy / isort aren't being run in CI without merging #268 first.

ch-kr commented 1 year ago

Yes, I just merged that other PR. Thank you for adding it, and for adding isort! My only remainining question here is around the version; it seems like the most recent mypy version is 1.0.0. Is there a reason you prefer v0.961?

ch-kr commented 1 year ago

pre-commit failures fixed in https://github.com/broadinstitute/regional_missense_constraint/pull/275

ch-kr commented 1 year ago

closing; duplicated in https://github.com/broadinstitute/regional_missense_constraint/pull/278