search

broadinstitute / seqr-loading-pipelines

hail-based pipelines for annotating variant callsets and exporting them to elasticsearch
MIT License
22 stars 20 forks source link

fix test tables for new clinvar assertions #707

Closed jklugherz closed 8 months ago

jklugherz commented 8 months ago

fix test cases for my accidental dev commit which adds new assertions and gold star lookup values

bpblanken commented 8 months ago

@hanars so you see this. We encountered changes to the "assertions" modifiers that were parsing away from the pathogenicities. If we continue to see frequent naming changes to these we should probably change the behavior to not hard-fail and instead dynamically map the enums. We're not doing anything on the search end other than returning in the JSON response and displaying in the UI right?

hanars commented 8 months ago

yeah, seqr has nothing hard coded around assertions so theres no harm if these dynamically update

bpblanken commented 8 months ago

merging so I can pull into my other branch