Closed lynnpais closed 1 year ago
We currently have two cut-off values (warningThreshold and dangerThreshold) and three colors(green for benign, yellow for warning, and red for danger). Does it mean we need four thresholds and five colors for this ticket?
@lynnpais do you want us to keep the current 3-color system and combine the green and reds in the above chart, or do you want us to switch to a 5-color system?
Move all to the a new 6-color system using the ranges in the image above - Benign: Very strong + Strong = dark green Benign: Moderate + Supporting = light green VUS: In between ranges benign supporting and pathogenic supporting = Grey Pathogenic Supporting = orange Pathogenic Moderate = red Pathogenic Strong + very strong = dark red
coding implementation notes - we should switch warningThreshold
and dangerThreshold
to an array threshholds
, rather than try to maintain 5 different variables
@lynnpais is there any flexibility for the colors? It is possible to implement with the colors you propsed, but we could use the built-in color schemes from our UI library if we tweaked it a little, which creates a more consistent UI across seqr than when we need to add custom colors to everything. The colors would be as follows: Benign: green Benign: light green VUS: Grey Pathogenic Supporting: yellow Pathogenic Moderate: orange Pathogenic Strong: red
Good to be consistent with existing UI colors. Okay to go with colors for - Benign: green Benign: light green VUS: Grey Pathogenic Supporting: yellow (I take it is the same yellow we are using for the in silicos)
For the last two, Pathogenic Moderate: red (existing red) Pathogenic Strong: dark red (one new color. Only a very few variants will actually have this color).
The reason is that most variants currently showing red will be orange as they fall in the moderate range per the new ClinGen guidelines. None of the variants will ever have a red CADD score. All this can be confusing to an analyst, so propose to have one new dark red color to differentiate.
It would also be great to have these ranges and corresponding colors shown in the hover over like we currently do.
Makes sense. Would this purple be acceptable for the very strong pathogenic? If not, we can make dark red work
Favor a darker red over purple.
Can the polyphen
in seqr use the above thresholds for the PolyPhen2
?
Its the same thing, the ui code has friendly names for things but if you look at the server side mapping code you can see what the data source for everything is: https://github.com/broadinstitute/seqr/blob/master/seqr/utils/search/elasticsearch/constants.py#L345
Suppose a prediction doesn't have a benign threshold but has a pathogenic supporting point. What color should we display for the value smaller than the pathogenic supporting threshold? Grey, light green, or green?
colors/thresholds should map to the image included in the description, which is pretty unambiguous. What is a specific example of a score hwere there is ambiguity about what to show?
For example, if a score of 1.1 for MPC, what color should it display?
light green
Why not grey?
@lynnpais your call
Let's go with grey [ClinGen paper states they were not able to identify thresholds for benignity (BP4) for MPC]
scores have been updated
Is your feature request related to a problem? Please describe. The analyst team would like to request an update to the colors used for the in silico scores based on new guidelines from ClinGen. These changes should apply to all in silico tools (CADD, MPC, MutPred2, PrimateAi, REVEL, SIFT, VEST4) used in seqr and represented in the table below.
Describe the solution you'd like
Benign: Very strong + Strong = dark green Benign: Moderate + Supporting = light green VUS: In between ranges benign supporting and pathogenic supporting = Grey Pathogenic Supporting = orange Pathogenic Moderate = red Pathogenic Strong + very strong = dark red
The cutoff ranges can also be found here in Table 2 - https://www.ncbi.nlm.nih.gov/pmc/articles/PMC9748256/
Describe alternatives you've considered NA
Additional context Discussed during analyst team meeting.