search

broadinstitute / single_cell_portal

Tutorials, workflows, and convenience scripts for Single Cell Portal
https://singlecell.broadinstitute.org/single_cell
BSD 3-Clause "New" or "Revised" License
47 stars 25 forks source link

update manage-study to handle full_description (SCP-2661) #106

Closed jlchang closed 4 years ago

jlchang commented 4 years ago

Studies where full_description is Null will fail to load in the Portal. This PR updates scp_api.py so description text is passed as full_description under study_detail_attributes. Also increments version for push to PyPI.

This satisfies SCP-2661.

Testing for regression of this issue will require manual testing (study creation did not break, only trying to load the created study).

codecov[bot] commented 4 years ago

Codecov Report

Merging #106 into master will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   22.07%   22.07%           
=======================================
  Files          17       17           
  Lines        2809     2809           
=======================================
  Hits          620      620           
  Misses       2189     2189
Impacted Files Coverage Δ
scripts/scp_api.py 45.91% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d72189c...f5958c7. Read the comment docs.