broadinstitute / single_cell_portal_core

Rails/Docker application for the Broad Institute's single cell RNA-seq data portal
https://singlecell.broadinstitute.org
BSD 3-Clause "New" or "Revised" License
62 stars 26 forks source link

Addressing various CodeQL security alerts #2103

Closed bistline closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.64%. Comparing base (b956149) to head (f073de5).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/broadinstitute/single_cell_portal_core/pull/2103/graphs/tree.svg?width=650&height=150&src=pr&token=HMWE5BO2a4&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute)](https://app.codecov.io/gh/broadinstitute/single_cell_portal_core/pull/2103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute) ```diff @@ Coverage Diff @@ ## development #2103 +/- ## =============================================== + Coverage 69.62% 69.64% +0.02% =============================================== Files 324 324 Lines 27265 27273 +8 Branches 2251 2251 =============================================== + Hits 18982 18994 +12 + Misses 8158 8154 -4 Partials 125 125 ``` | [Files](https://app.codecov.io/gh/broadinstitute/single_cell_portal_core/pull/2103?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute) | Coverage Δ | | |---|---|---| | [.../controllers/api/v1/concerns/convention\_schemas.rb](https://app.codecov.io/gh/broadinstitute/single_cell_portal_core/pull/2103?src=pr&el=tree&filepath=app%2Fcontrollers%2Fapi%2Fv1%2Fconcerns%2Fconvention_schemas.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute#diff-YXBwL2NvbnRyb2xsZXJzL2FwaS92MS9jb25jZXJucy9jb252ZW50aW9uX3NjaGVtYXMucmI=) | `90.62% <100.00%> (+6.41%)` | :arrow_up: | | [.../controllers/api/v1/metadata\_schemas\_controller.rb](https://app.codecov.io/gh/broadinstitute/single_cell_portal_core/pull/2103?src=pr&el=tree&filepath=app%2Fcontrollers%2Fapi%2Fv1%2Fmetadata_schemas_controller.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute#diff-YXBwL2NvbnRyb2xsZXJzL2FwaS92MS9tZXRhZGF0YV9zY2hlbWFzX2NvbnRyb2xsZXIucmI=) | `94.54% <100.00%> (-0.62%)` | :arrow_down: | | [app/controllers/api/v1/study\_files\_controller.rb](https://app.codecov.io/gh/broadinstitute/single_cell_portal_core/pull/2103?src=pr&el=tree&filepath=app%2Fcontrollers%2Fapi%2Fv1%2Fstudy_files_controller.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute#diff-YXBwL2NvbnRyb2xsZXJzL2FwaS92MS9zdHVkeV9maWxlc19jb250cm9sbGVyLnJi) | `83.95% <100.00%> (ø)` | | | [app/models/ann\_data\_file\_info.rb](https://app.codecov.io/gh/broadinstitute/single_cell_portal_core/pull/2103?src=pr&el=tree&filepath=app%2Fmodels%2Fann_data_file_info.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute#diff-YXBwL21vZGVscy9hbm5fZGF0YV9maWxlX2luZm8ucmI=) | `97.00% <100.00%> (+0.09%)` | :arrow_up: | | [app/models/delete\_queue\_job.rb](https://app.codecov.io/gh/broadinstitute/single_cell_portal_core/pull/2103?src=pr&el=tree&filepath=app%2Fmodels%2Fdelete_queue_job.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute#diff-YXBwL21vZGVscy9kZWxldGVfcXVldWVfam9iLnJi) | `62.58% <100.00%> (ø)` | | | [app/models/study.rb](https://app.codecov.io/gh/broadinstitute/single_cell_portal_core/pull/2103?src=pr&el=tree&filepath=app%2Fmodels%2Fstudy.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute#diff-YXBwL21vZGVscy9zdHVkeS5yYg==) | `82.06% <100.00%> (+0.36%)` | :arrow_up: | | [app/models/study\_detail.rb](https://app.codecov.io/gh/broadinstitute/single_cell_portal_core/pull/2103?src=pr&el=tree&filepath=app%2Fmodels%2Fstudy_detail.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute#diff-YXBwL21vZGVscy9zdHVkeV9kZXRhaWwucmI=) | `100.00% <100.00%> (ø)` | | | [app/models/study\_file.rb](https://app.codecov.io/gh/broadinstitute/single_cell_portal_core/pull/2103?src=pr&el=tree&filepath=app%2Fmodels%2Fstudy_file.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute#diff-YXBwL21vZGVscy9zdHVkeV9maWxlLnJi) | `81.04% <100.00%> (+0.02%)` | :arrow_up: | | [app/models/taxon.rb](https://app.codecov.io/gh/broadinstitute/single_cell_portal_core/pull/2103?src=pr&el=tree&filepath=app%2Fmodels%2Ftaxon.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute#diff-YXBwL21vZGVscy90YXhvbi5yYg==) | `86.82% <ø> (+1.53%)` | :arrow_up: | | [lib/validation\_tools.rb](https://app.codecov.io/gh/broadinstitute/single_cell_portal_core/pull/2103?src=pr&el=tree&filepath=lib%2Fvalidation_tools.rb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute#diff-bGliL3ZhbGlkYXRpb25fdG9vbHMucmI=) | `100.00% <ø> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/broadinstitute/single_cell_portal_core/pull/2103/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=broadinstitute)