Closed bistline closed 1 month ago
Attention: Patch coverage is 0%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 69.83%. Comparing base (
67388b2
) to head (1556395
). Report is 67 commits behind head on development.
Files | Patch % | Lines |
---|---|---|
app/models/ingest_job.rb | 0.00% | 7 Missing :warning: |
Code looks good, manual tests passed! Beyond this and SCP-5764, is there more needed to enable DE for AnnData?
BACKGROUND & CHANGES
Building on #2113 and 359, this update adds end-to-end integration for raw counts extraction of AnnData files. When a user uploads an AnnData file for parsing we will extract the list of cells corresponding to both the raw and processed matrices. This is part of an effort to enable exploratory differential expression for AnnData files. New AnnData uploads that specify they have raw counts information will now be marked as eligible for differential expression.
Note: there is not a backfill migration for existing AnnData files as we do not know whether they have raw counts data in the
adata.raw
slot. Study owner outreach will be required in order to identify potential raw counts files. Also, while these new AnnData studies will be eligible for differential expression, there is still work to be done in order to fully enable this. Once that has completed and we have identified any potential existing studies w/ raw counts data, we can run a backfill migration to add differential expression results.MANUAL TESTING
study.has_visualization_matrices? => true
study.has_expression_data? => true
study.expression_matrix_cells(study_file, matrix_type: 'raw').count => 2638
study.expression_matrix_cells(study_file, matrix_type: 'processed').count => 2638
DifferentialExpressionService.study_eligible?(study) => true
DifferentialExpressionService.find_eligible_annotations(study) => [{:annotation_name=>"louvain", :annotation_scope=>"study"}]