broadinstitute / tensorqtl

Ultrafast GPU-enabled QTL mapper
BSD 3-Clause "New" or "Revised" License
162 stars 52 forks source link

An error in tensorqtl_examples.ipynb ? #76

Closed taeyoungh closed 2 years ago

taeyoungh commented 2 years ago

Hi, I am testing tensorqtl_examples.ipynb and had an error in line 3 "cis-eQTL: nominal p-values": cis.map_nominal(genotype_df, variant_df, phenotype_df, phenotype_pos_df, covariates_df, prefix). But, it seems that the argument locations of covariates_df and prefix are different from the definition. Should it be cis.map_nominal(genotype_df, variant_df, phenotype_df, phenotype_pos_df, prefix, covariates_df) ?

francois-a commented 2 years ago

Hi, that's correct, thanks for pointing this out. Fixed here.