In an effort to reduce some of the repetitiveness of the node pool configuration, this parameterizes the node pools, and then uses a for_each to create them from a common resource definition.
The benefits here are that it allows for much easier additions of new node pools in the future (or temporary additions), and for outside users, it allows them to define their pools in a way that might not mirror our default setup.
One drawback that I can see with this approach is that if we would like to change any part of the default node_pools values to differ from the defaults, it could result in some repetition in our environments where we use the module. But that case might be rare enough that it's not a big deal -- we don't often make changes to our node pools.
In an effort to reduce some of the repetitiveness of the node pool configuration, this parameterizes the node pools, and then uses a
for_eachto create them from a common resource definition.The benefits here are that it allows for much easier additions of new node pools in the future (or temporary additions), and for outside users, it allows them to define their pools in a way that might not mirror our default setup.
One drawback that I can see with this approach is that if we would like to change any part of the default node_pools values to differ from the defaults, it could result in some repetition in our environments where we use the module. But that case might be rare enough that it's not a big deal -- we don't often make changes to our node pools.