search

broadinstitute / viral-ngs

Viral genomics analysis pipelines
Other
187 stars 66 forks source link

add .git to .dockerignore #978

Closed tomkinsc closed 4 years ago

tomkinsc commented 4 years ago

add .git to .dockerignore to reduce the size of the build context sent to the Docker daemon (all of the files in the pwd)

dpark01 commented 4 years ago

hm... I forget, do we save the git commit hash anywhere within the docker image? If not, this means we lose the ability to be sure of that.. an alternative could be to do a git checkout depth 1 or something?

tomkinsc commented 4 years ago

Shoot, yes, we do use it internally during Docker build in the call to write the VERSION file. Docker copies the entire Travis working directory, which currently does have a limit to its checkout depth (set to 150). I'll close this.