broadinstitute / warp

WDL Analysis Research Pipelines
https://broadinstitute.github.io/warp
BSD 3-Clause "New" or "Revised" License
201 stars 93 forks source link

PD-2559andPD-2558: UMI filtering and cell barcode correction #1263

Closed aawdeh closed 4 months ago

aawdeh commented 5 months ago

Combined two tickets into one to test out changes and merge changes combined

Tackling both UMI filtering and cell barcode correction

Changed/Added starsolo parameters:

Smart tests failed on: dev_10k_pbmc_downsampled, pbmc_human_v3, mouse_v2_snRNA_example and snRNA_mouse_v2_snRNA_example

Notebook to compare failed smart tests: https://app.terra.bio/#workspaces/warp-pipelines/Multiome-test-workspace/analysis/launch/PD2559_PD2558_umi_filtering_and_cell_barcode_correction.ipynb?mode=edit

Description

Give your PR a concise yet descriptive title. Please explain the changes you made here. Explain the motivation for making this change. What existing problem does the pull request solve? Mention any issues fixed, addressed, or otherwise related to this pull request, including issue numbers or hard links for issues in other repos. You can delete these instructions once you have written your PR description.


Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP documentation team by tagging either @ekiernan or @kayleemathews in a comment on this PR.

github-actions[bot] commented 5 months ago

Remember to squash merge!

github-actions[bot] commented 5 months ago

Remember to squash merge!

github-actions[bot] commented 4 months ago

Remember to squash merge!

github-actions[bot] commented 4 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
All WDLs and changelog files appear to be valid for this release.
github-actions[bot] commented 4 months ago

Remember to squash merge!

github-actions[bot] commented 4 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
All WDLs and changelog files appear to be valid for this release.
github-actions[bot] commented 4 months ago

Remember to squash merge!

github-actions[bot] commented 4 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
All WDLs and changelog files appear to be valid for this release.
ekiernan commented 4 months ago

retest this please

ekiernan commented 4 months ago

retest this please