broadinstitute / warp

WDL Analysis Research Pipelines
https://broadinstitute.github.io/warp
BSD 3-Clause "New" or "Revised" License
201 stars 93 forks source link

Made changes for SnapATAC2 v2.6.0 #1273

Closed ekiernan closed 3 months ago

ekiernan commented 4 months ago

Description

Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP documentation team by tagging either @ekiernan or @kayleemathews in a comment on this PR.

github-actions[bot] commented 4 months ago

Remember to squash merge!

github-actions[bot] commented 4 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed
github-actions[bot] commented 4 months ago

Remember to squash merge!

github-actions[bot] commented 4 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed
github-actions[bot] commented 4 months ago

Remember to squash merge!

github-actions[bot] commented 4 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed
github-actions[bot] commented 4 months ago

Remember to squash merge!

github-actions[bot] commented 4 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed
github-actions[bot] commented 4 months ago

Remember to squash merge!

github-actions[bot] commented 4 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed
github-actions[bot] commented 4 months ago

Remember to squash merge!

github-actions[bot] commented 4 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed
github-actions[bot] commented 4 months ago

Remember to squash merge!

github-actions[bot] commented 4 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed
github-actions[bot] commented 4 months ago

Remember to squash merge!

github-actions[bot] commented 4 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed
github-actions[bot] commented 4 months ago

Remember to squash merge!

github-actions[bot] commented 4 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed
ekiernan commented 4 months ago

retest this please

github-actions[bot] commented 4 months ago

Remember to squash merge!

github-actions[bot] commented 4 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
atac.wdl has not had its version updated
Multiome.wdl has not had its version updated
Some WDLs or changelog files need updating. See output for details.
validation_failed
github-actions[bot] commented 3 months ago

Remember to squash merge!

github-actions[bot] commented 3 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.wdl has not had its version updated
atac.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
PairedTag.wdl has not had its version updated
Optimus.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed
github-actions[bot] commented 3 months ago

Remember to squash merge!

github-actions[bot] commented 3 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.wdl has not had its version updated
atac.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
PairedTag.wdl has not had its version updated
Optimus.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed
github-actions[bot] commented 3 months ago

Remember to squash merge!

github-actions[bot] commented 3 months ago

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.wdl has not had its version updated
atac.wdl has not had its version updated
SlideSeq.wdl has not been changed and needs updating
Optimus.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed
ekiernan commented 3 months ago

Link to scientific tests here:https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/76718/consoleFull

The differences in the h5ad files are relatively minor and expected

github-actions[bot] commented 3 months ago

Remember to squash merge!

github-actions[bot] commented 3 months ago

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.changelog.md has not been changed and needs to be updated
atac.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed
github-actions[bot] commented 3 months ago

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.
github-actions[bot] commented 3 months ago

Remember to squash merge!

github-actions[bot] commented 3 months ago

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.changelog.md has not been changed and needs to be updated
atac.changelog.md has not been changed and needs to be updated
SlideSeq.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed
github-actions[bot] commented 3 months ago

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.
github-actions[bot] commented 3 months ago

Remember to squash merge!

github-actions[bot] commented 3 months ago

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.
github-actions[bot] commented 3 months ago

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
SlideSeq.wdl and SlideSeq.changelog.md do not have matching versions
Some WDLs or changelog files need updating. See output for details.
validation_failed
github-actions[bot] commented 3 months ago

Remember to squash merge!

github-actions[bot] commented 3 months ago

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.
github-actions[bot] commented 3 months ago

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.
ekiernan commented 3 months ago

Fragment file differences in paired-tag data are the result of sorting - when we sort the files, the md5sums match. For example, the BI015 sample: 54b66cf8c81392595a15c9480612a33d sorted.test.tsv 54b66cf8c81392595a15c9480612a33d sorted.truth.tsv

github-actions[bot] commented 3 months ago

Remember to squash merge!

github-actions[bot] commented 3 months ago

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.
github-actions[bot] commented 3 months ago

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.
github-actions[bot] commented 3 months ago

Remember to squash merge!

github-actions[bot] commented 3 months ago

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.
github-actions[bot] commented 3 months ago

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.
ekiernan commented 3 months ago

retest this please