search

broadinstitute / warp

WDL Analysis Research Pipelines
https://broadinstitute.github.io/warp
BSD 3-Clause "New" or "Revised" License
200 stars 93 forks source link

staging --> master #1287

Closed ekiernan closed 2 months ago

ekiernan commented 3 months ago

staging --> master

github-actions[bot] commented 3 months ago

DO NOT SQUASH MERGE!!!

github-actions[bot] commented 3 months ago

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/master':
All changelog files are valid for this release.
github-actions[bot] commented 3 months ago

🔍Version Validation Results:

basename: missing operand
Try 'basename --help' for more information.
Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.
ekiernan commented 2 months ago

Updated Truth for Multiome and Optimus off of staging. Scientific tests for Multiome are running here: https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/77322/

Scientific test for Optimus are running here: https://gotc-jenkins.dsp-techops.broadinstitute.org/job/warp-workflow-tests/77323/

Paired-tag failures are because we have not officially added scientific tests, so the json is malformed. https://cromwell.gotc-dev.broadinstitute.org/api/workflows/1/c5cdb8b7-27ae-4a91-9c81-9077c9737216/metadata

ExomeReprocessing is failing due to misordered crosscheck rows. There are no functional changes to the outputs. ExomeGermlineSingleSample is failing due to misordered crosscheck rows. There are no functional changes to the outputs.

github-actions[bot] commented 2 months ago

DO NOT SQUASH MERGE!!!

github-actions[bot] commented 2 months ago

🔍Version Validation Results:

basename: missing operand
Try 'basename --help' for more information.
Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.
github-actions[bot] commented 2 months ago

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/master':
All changelog files are valid for this release.
ekiernan commented 2 months ago

retest this please

ekiernan commented 2 months ago

WGS Metrics were validated in this spreadsheet.

We confirmed that the differences in metrics were likely due to non-determinism. We reran the tests from master and saw similar failures in WGS tasks. The run scientific run from master is here.

We did find a previous PR that is supposed to remove non-determinism here and we saw that we reverted this PR in a separate PR here because the scientific tests were failing. We could revisit this in the future.

ekiernan commented 2 months ago

Paired-tag now fails because there is no scientific test provided. This will be provided on a separate release of the pipeline.