broadinstitute / wdl-ide

Rich IDE support for Workflow Description Language
BSD 3-Clause "New" or "Revised" License
40 stars 8 forks source link

WDL Devtools for VSCode rendering non-breaking whitespace causing errors #13

Open maribuon opened 3 years ago

maribuon commented 3 years ago

Hi,

thank you for the plugin. It is very useful. However, since I have started using OneDrive for business (which has whitespaces on the name), files cannot be found because the whitespaces are replaced with %20 (or 20%). I am using it on MacOS, but had to unable it, unfortunately. It would be great if that can be fixed.

Best wishes, Mariana

dinvlad commented 3 years ago

OK, thanks for reporting! Could you give examples of the files that cannot be found? Are those the files in your workspace or some files from the plugin?

maribuon commented 3 years ago

Hi,

it happens to the very same script that I am editing, and it happens exactly when I change anything on the file, the output says:

[Info  - 4:31:00 PM] Validating file:///Users/username/OneDrive%20-%20Business%20something%20Ltd/projects/SV_CNV/dev_sv_cnv_workflow/dev_username/svcnvCatchCore.wdl
[Error - 4:31:00 PM] [Errno 2] No such file or directory: '/Users/username/OneDrive%20-%20Business%20something%20Ltd/projects/SV_CNV/dev_sv_cnv_workflow/dev_username/svcnvCatchCore.wdl'
dinvlad commented 3 years ago

OK, I see! That's interesting - and does it happen only on OneDrive files or any file paths that have spaces in them?

maribuon commented 3 years ago

Same thing on other "space-named" dir:

[Info  - 4:56:21 PM] Validating file:///Users/username/space%20test/space/svcnvCatchCore.wdl
[Error - 4:56:21 PM] [Errno 2] No such file or directory: '/Users/username/space%20test/space/svcnvCatchCore.wdl'
dinvlad commented 3 years ago

Thanks! That certainly seems like a bug we overlooked. I'll take a look into a fix