search

broadinstitute / wdl-ide

Rich IDE support for Workflow Description Language
BSD 3-Clause "New" or "Revised" License
40 stars 8 forks source link

Open MiniWDL install range #9

Closed illusional closed 3 years ago

illusional commented 3 years ago

I can't see a reason it was locked to 0.5.1, but it's been 18 months since that release.

mlin commented 3 years ago

Pinning the exact version was reasonable at the time when miniwdl wasn't yet stable. Nowadays, it should be pretty safe to allow variance in the patch version and perhaps the minor version too.

illusional commented 3 years ago

Thanks @mlin, happy for you to make edits to my PR (if you can). Or happy to modify it if you have a suggestion.

dinvlad commented 3 years ago

@illusional did you get a chance to test if the VSCode plugin works locally with this version upgrade? If it does still, then I'll merge.

illusional commented 3 years ago

Hi @dinvlad, sorry for the extra time to review this, turns out every time I was trying to test this, the extension was pip-installing the old miniWDL back over the top (I suspect from here: https://github.com/broadinstitute/wdl-ide/blob/35ad44f3bb041e58332ffe58c9e7d3fce9356ac3/client/vscode/src/extension.ts#L94)

I made two additional changes to the server:

For this reason, I've restricted it to >= 1.1.5.

It works now, and confirmed the update by not seeing an error message that doesn't exist in newer versions of MiniWDL.

dinvlad commented 3 years ago

turns out every time I was trying to test this, the extension was pip-installing the old miniWDL

sounds so familiar! :)

It works now, and confirmed the update by not seeing an error message that doesn't exist in newer versions of MiniWDL.

Awesome! LGTM and merging. I'll mark it as a new release and post here when it's ready.

dinvlad commented 3 years ago

Alright, finally published! https://marketplace.visualstudio.com/items?itemName=broadinstitute.wdl-devtools I had to upgrade a few more dependencies, and our expired publishing token :) Please let me know if the new version works for you!