Witness types in Cwl constructors

broadinstitute / wdl4s

Scala bindings for WDL

3 stars 5 forks source link

Witness types in Cwl constructors #214

Closed danbills closed 7 years ago

danbills commented 7 years ago

nicely omitted when writing Cwl
asserted during JSON Parsing

Some eggs were broken when updating Circe to use Cats 1.0.0-MF:

circe-yaml is lagging, pointing to cats 0.9.0. Thus ability to write YAML has been removed. The tests have been retained but ignored in case we restore this functionality. I know cromwell doesn't depend on this functionality and I don't know @curoli 's needs but this is necessary until

that dependency situation is fixed on circe-yaml.
we use another yaml library

danbills commented 7 years ago

seems I threw the Json writing baby out with the bathwater. I'll bring it back

mcovarr commented 7 years ago

:+1:

curoli commented 7 years ago

Awesome, thanks!

I don't need CWL-YAML in particular if I can get CWL-JSON (and I can always convert).