search

broadinstitute / wdl4s

Scala bindings for WDL
3 stars 5 forks source link

Call Inputs v3 #223

Closed Horneth closed 7 years ago

Horneth commented 7 years ago

New attempt at call node creation, this time most of the logic is handled by language specific code. This generates a lot of boilerplate code when creating nodes from WOM directly which shows in the tests.

Horneth commented 7 years ago

@cjllanwarne @danbills re "it shouldn't be a fold" I got it to work by having the InputDefinitionFold be a monoid and map/traverse the list + combineAll at the end but I honestly don't think it changes much, readability looks the same to me. And unless we parallelize the map it'll still do it in order so..

danbills commented 7 years ago

I was thinking of foldMap but yeah it's just a small win

Horneth commented 7 years ago

@danbills I gave it a shot (last commit)