Full overhaul of the repository

peterhav commented 4 years ago

To the developer of this library,

I have been using this library in one of my Android applications and really appreciate it. Recently I have migrated all my sources to Android X and found this library to be the last dependency that was not yet using AndroidX. After looking at the sources; I've decided to make several more improvements and ended up with the list below:

Updates

Material Components (removes material search view dependency that is no longer required)
Material styling/theming (end users only need to supply their colors.xml (custom_colors.xml in the sample) and themes.xml, if not provided default library colors are used
Kotlin coroutines/Flow instead of RxLibrary (removing dependency to io.reactivex.rxjava2)
Navigation (instead of Builder) mainly for safe arguments (end users can integrate the fragment using a navgraph)
Kotlin instead of Java
AndroidX (automatic migration, jetifier disabled since all dependencies use androidx)
Introduction of viewmodels (state changes and sharing of result)
Single Fragment (in line with the single activity recommendation and for easy integration)
Databinding for the UIs
Timber dependency added for logging
Permission requester integration
Hilt dependency injection is used for easy viewmodel injection (note that the sharedviewmodel works at activity level, which makes the picked contacts result communication
Strings are now arguments using resource identifiers n order to facilitate users to add customization and internationalization of any text used
Sample app added, that shows how the contactspicker can be used

I've tried to keep the original code and interface in place where possible. Happy for you to decide if you want to use this or not. Kind regards, Peter

broakenmedia commented 4 years ago

Excellent stuff Peter... thank you. I sadly have not had the time to work on this anymore and my primary development platform is no longer Android which makes it even harder! I've invited you as a collaborator on the project, please feel free to integrate this changes as you see fit :)

peterhav commented 4 years ago

Hi J,

thank you very much. I'm not yet up to speed on github and the library build system (android-maven-gradle-plugin) so that will take some more time to investigate. Once I have the possibility I will look into this further and try to prepare a new update! Thanks.

Kind regards, Peter

On Wed, 26 Aug 2020 at 21:42, J notifications@github.com wrote:

Excellent stuff Peter... thank you. I sadly have not had the time to work on this anymore and my primary development platform is no longer Android which makes it even harder! I've invited you as a collaborator on the project, please feel free to integrate this changes as you see fit :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/broakenmedia/MultiContactPicker/pull/52#issuecomment-680827721, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANE6PZFNWHQNEGDPK5TSD3SCTYKVANCNFSM4QLWJVYQ .

oscarito9410 commented 3 years ago

Guys, I'm interested on contributing in this repo. @peterhav may I take this branch and solved conflicts? CC: @broakenmedia

broakenmedia commented 3 years ago

Guys, I'm interested on contributing in this repo. @peterhav may I take this branch and solved conflicts? CC: @broakenmedia

Hello, you're welcome to contribute if still interested? Thanks.

broakenmedia / MultiContactPicker

Full overhaul of the repository #52