search

broamski / aws-fedcred

7 stars 9 forks source link

fedcred breaks on AD-SSO #5

Open zachzeid opened 7 years ago

zachzeid commented 7 years ago

fedcred is looking for aws specific SAML and strips out the pertinent parts for gain aws credentials. This breaks when there is AD-SSO in front for user authentication and there is a redirect. Fedcred does not handle login there as it strips out the url

expected behavior action=https://signin.aws.amazon.com/saml

behavior with AD-SSO action=/adfs/ls/?SAMLRequest=<saml>

zachzeid commented 7 years ago

Suggested solution here: https://github.com/broamski/aws-fedcred/pull/6