search

brocaar / chirpstack-api

ChirpStack API (Protobuf & gRPC)
MIT License
67 stars 82 forks source link

Sdk java #34

Closed mattocchi closed 3 years ago

mattocchi commented 3 years ago

updated the main README on java section

brocaar commented 3 years ago

updated the main README on java section

Could you please check the diff, this PR changes a bit more than just the README...

mattocchi commented 3 years ago

do not forget PR contains all previous commit that you already have merged (from same branch), missing changes are only from last commit currently (maybe you prefer to receive a specific PR per each feature change, maybe we will close this PR)

brocaar commented 3 years ago

do not forget PR contains all previous commit that you already have merged (from same branch)

Correct, but these should not show up in the diff if these have already been merged :) Could you merge back the brocaar/chirpstack-api master branch into your branch and push this merge to your fork? I think that should solve the issue.

Else I have to re-review all other changes again to make sure no other changes are merged in accidentally.

brocaar commented 3 years ago

I have merged back the master branch into your PR. This made the diff a lot easier to review :)