search

brocaar / chirpstack-network-server

ChirpStack Network Server is an open-source LoRaWAN network-server.
https://www.chirpstack.io
MIT License
1.48k stars 545 forks source link

Misleading label for LoRa frames #613

Closed vsaljooghi closed 1 month ago

vsaljooghi commented 1 month ago

What happened?

When I look in Chirpstack GUI for LoRaWAN Frames, the events naming/label is confusing.

For example: ConfirmedDataDown label uses a past tense verb (confirmed) to describe an event which will happen in future (confirmation/acknowledgment will happen with receive of next uplink)

What did you expect?

ConfirmedDataUp --> DataUpRequiringConfirmation ConfirmedDataDown --> DataDownRequiringConfirmation UncomfirmedDataUp --> DataUpRequiringNoConfirmation UncomfirmedDataDown --> DataDownRequiringNoConfirmation

Steps to reproduce this issue

Steps:

1. 2. 3. 4.

Could you share your log output?

Your Environment

Component Version
Application Server v?.?.?
Network Server
Gateway Bridge
Chirpstack API
Geolocation
Concentratord
brocaar commented 1 month ago

The naming is aligned with the naming in the LoRaWAN specification (see MType field in the specification). I'm not planning to use different MType names that officially specified because this would become very confusing.

On Wed, May 8, 2024, 20:56 Vahid Saljooghi @.***> wrote:

What happened?

When I look in Chirpstack GUI for LoRaWAN Frames, the events naming/label is confusing.

For example: ConfirmedDataDown label uses a past tense (confirmed) to describe an event which will happen in future (confirmation/acknowledgment will happen with receive of next uplink) What did you expect?

ConfirmedDataUp --> DataUpRequiringConfirmation ConfirmedDataDown --> DataDownRequiringConfirmation UncomfirmedDataUp --> DataUpNotRequiringConfirmation UncomfirmedDataDown --> DataDownNotRequiringConfirmation Steps to reproduce this issue

Steps:

1. 2. 3. 4.

Could you share your log output?

Your Environment Component Version Application Server v?.?.? Network Server Gateway Bridge Chirpstack API Geolocation Concentratord

— Reply to this email directly, view it on GitHub https://github.com/brocaar/chirpstack-network-server/issues/613, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABIM6I5LH3TOUI6D72GHS3ZBJ7NDAVCNFSM6AAAAABHNS2UNWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI4DMMZTGMZTGOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mmrein commented 1 month ago

The proposed way is also roughtly 2x longer and far less readable. @vsaljooghi Look at it like this: ConfirmedDataUp = uplink data that must be confirmed (in the future)