search

brocade / ansible

55 stars 33 forks source link

Fix for cfgsave/cfgenable overwritten by later commit. #138

Open xsYf6tdq8 opened 1 year ago

xsYf6tdq8 commented 1 year ago

Hi

The fix for the cfgsave issue mentioned in https://github.com/brocade/ansible/issues/100#issuecomment-1111306389 has been made in commit https://github.com/brocade/ansible/commit/447a0639ffc3f62e60105c9f1e70794e2b5f859e but has been overwritten (or rolled back) via commit https://github.com/brocade/ansible/commit/9d0d60d7afc2bee6160559bfabe32ccfbda49fed#r123304744. The cfgsave was only implemented when deleting zones and not when adding.

For us this is quite a big issue as we don't want cfgenable with each new zone.

Wrong code:

                    if cfgname is not None:
                        failed_msg = "CFG ENABLE failed"
                        ret_code = cfg_enable(fos_ip_addr, https, auth, vfid,
                                            result, checksum, cfgname, timeout)
                    else:
                        failed_msg = "CFG SAVE failed"
                        ret_code = cfg_save(fos_ip_addr, https, auth, vfid,

Should be replaced with:

                 failed_msg = "CFG SAVE failed"
                    ret_code = cfg_save(fos_ip_addr, https, auth, vfid,
prasad-valmeti-broadcom commented 1 year ago

Thanks for letting us know. We will look into it and get back to you.