search

brocade / ansible

56 stars 33 forks source link

telnet_timeout is now shell_timeout #147

Open mgoetze5 opened 9 months ago

mgoetze5 commented 9 months ago

Several of the examples set telnet_timeout in brocade_chassis. In FOS 9.1, this parameter doesn't exist, instead there is shell_timeout.

prasad-valmeti-broadcom commented 6 months ago

telnet_timeout is referring to shell_timeout only. telnet_timeout is set to the response by parsing the SSH CLI output of the timeout command, earlier shell_timeout was not there through REST. shell_timeout was introduced from 9.1 onwards. If there are no functionality issues, we can leave it as is for backward compatibility. Please let us know your suggestions on this.

mgoetze5 commented 6 months ago

I don't think any functional changes are needed but I would recommend having the documentation and examples reflect the way it works in the newer version, so changing switch_change_all.yml, template_switch_change_all.yml, template_switch_initial_config.yml and library/brocade_chassis.py.