search

broccolijs / broccoli-funnel

MIT License
66 stars 37 forks source link

CI is broken on Windows for v3.0.0 #119

Open Turbo87 opened 4 years ago

Turbo87 commented 4 years ago

/cc @stefanpenner

stefanpenner commented 4 years ago

Windows test is failing at broken link test because of nodejs/node#30538

context: https://github.com/broccolijs/broccoli-funnel/pull/117#issuecomment-561953127 commit to fix in node: https://github.com/pd4d10/node/commit/842dcf3264fcd9da37e6336dd98c650e3f555d80

TL;DR: bug in node, hopefully they release new patch versions with the fix soon. If not, we can consider skipping those tests. @turbo87 thoughts?

Turbo87 commented 4 years ago

is that a problem in our tests or in the library code? I'm wondering if we need a workaround for the node versions that have this bug?

stefanpenner commented 4 years ago

TL;DR existsSync is sorta broken. We could provide a wrapper that likely works around it, but we can't really guarentee all other usages of it in an app are using said wrapper. I kinda think (unless this appears in bug reports) that @SparshithNR approach of getting node core to fix is the right path.

But i can be convinced.