search

broccolijs / broccoli-funnel

MIT License
66 stars 37 forks source link

Stop gathering instantiation stack manually. #141

Closed rwjblue closed 3 years ago

rwjblue commented 3 years ago

This was added waaaaaay back in 46e1e23 (2014), long before the newer broccoli-plugin APIs (around Broccoli@1) started creating an instantiation stack to be used for error handling across the board.

Now that we extend from broccoli-plugin directly, we no longer have to do this manually. Additionally, the code in broccoli-plugin is authored such that it avoids touching the .stack property unless it is actually needed (forcing V8 to create the stack is costly).

Thanks to @krisselden for pointing this out.