search

broccolijs / broccoli-funnel

MIT License
66 stars 37 forks source link

Do not use CoreObject #26

Closed joliss closed 9 years ago

joliss commented 9 years ago

I'd like to derive from broccoli-plugin, but at the moment we're setting the __proto__ to CoreObject. (I'm a bit confused as to what this actually does - it looks like we're not subclassing, but using CoreObject as a meta class of some sort...) In any case, my impression is that this is unused, so we can simply get rid of it.

rwjblue commented 9 years ago

I'm in favor, however it is a potentially breaking change for folks subclassing Funnel (I am not aware of any though), so we should make sure to update the version appropriately...

joliss commented 9 years ago

I sometimes use GitHub code search to check for (public) usage in cases like this, but in this case I don't know what keywords to look for.

joliss commented 9 years ago

Folded into #28.