search

broccolijs / broccoli-funnel

MIT License
66 stars 37 forks source link

Update minimatch to avoid vulnerability #66

Closed knownasilya closed 8 years ago

rwjblue commented 8 years ago

Are there any breaking changes from 2.0.1 to 3.0.0? Seems like there may be...

knownasilya commented 8 years ago

I'm assuming the tests would have caught any issues..

rwjblue commented 8 years ago

HEHE, so much faith!

rwjblue commented 8 years ago

Looks like they stopped bundling the browser build, I don't spot other breaking changes in the diff.

https://github.com/isaacs/minimatch/compare/v2.0.10...v3.0.2

rwjblue commented 8 years ago

LGTM

@stefanpenner - r?

stefanpenner commented 8 years ago

r+

stefanpenner commented 8 years ago

released as v1.0.2

knownasilya commented 8 years ago

Sweet.

stefanpenner commented 8 years ago

thanks @knownasilya !