search

broccolijs / broccoli-funnel

MIT License
66 stars 37 forks source link

Avoid re-symlink when this.destPath is already symlinked #76

Closed huiyuan closed 8 years ago

hjdivad commented 8 years ago

This will add two i/o ops (exists, lstat) in the case where we have to sync, but saves us a lot more in the nothing-to-do case.

LGTM

hjdivad commented 8 years ago

@stefanpenner @rwjblue thoughts?

stefanpenner commented 8 years ago

This looks good, but we do need at-least one regression test ensuring the corrected behavior works as intended.

stefanpenner commented 8 years ago

merged and released :)