broccolijs / broccoli-persistent-filter

MIT License
12 stars 33 forks source link

Worker is terminated #169

Open rafaelbnp opened 5 years ago

rafaelbnp commented 5 years ago

We're having the following build error since yesterday. I'm not able to reproduce locally yet but it fails on our CI when running ember test. I've tried many different things but the error persists. This is blocking our builds so any help would be much appreciated.

Note that this time it mentioned 'ember-data-copyable' but sometimes it mentions a different dependency so not sure if that's relevant.

Build Error (broccoli-persistent-filter:Babel > [Babel: ember-data-copyable]) in ember-data-copyable/-private/symbols.js

Worker is terminated
stefanpenner commented 5 years ago

We’ve been trying to improve the error messages that come out of workerpool.

Could you share the version of workerpool that is being pulled in? I want to see if your in an old version, or if there are additional issues to resolve.

Also, to debug this further please set the environment variable JOBS=1. That should run the worker code in the main thread and potentially provide a more useful stacktrace.

rafaelbnp commented 5 years ago

Actually, after setting the environment variable JOBS=1 it worked 🎉

Looks like there's an issue with parallelism added to broccoli-babel-transpiler and the fix is to set the JOBS environment variable to 1 to essentially disable the parallelism on CI.

Thanks @stefanpenner for getting back to me on this and please let me know if you think this is not the proper fix.

References: https://github.com/emberjs/ember.js/issues/15641 https://github.com/babel/broccoli-babel-transpiler#number-of-jobs https://github.com/mwisner/ember-ci-examples/blob/master/.circleci/config.yml

stefanpenner commented 5 years ago

@rafael-paiva well, I wouldn't consider that fixed. Maybe a work-around.

Do you have a reproduction?

rafaelbnp commented 5 years ago

Right, I needed at least a quick work around to unblock my builds.

@stefanpenner like I said I can't even reproduce this on my local env, it only fails on CI so I assumed it had something to do with this parallelism issue on CIs. Although I'm not sure why it started happening now. I don't know what else information I can give you. If you can guide me I'd be happy to help.

Could you share the version of workerpool that is being pulled in?

Does this help?

$ npm ls workerpool
client
├─┬ ember-bootstrap-datetimepicker@1.1.0
│ ├─┬ ember-cli-babel@5.2.8
│ │ └─┬ broccoli-babel-transpiler@5.7.4
│ │   └── workerpool@2.3.0  deduped
│ └─┬ ember-runtime-enumerable-includes-polyfill@1.0.4
│   └─┬ ember-cli-babel@5.2.8
│     └─┬ broccoli-babel-transpiler@5.7.4
│       └── workerpool@2.3.0  deduped
├─┬ ember-cli@3.4.3
│ └─┬ broccoli-babel-transpiler@6.5.0
│   └── workerpool@2.3.0 
├─┬ ember-cli-active-link-wrapper@0.3.0
│ └─┬ ember-cli-babel@5.2.8
│   └─┬ broccoli-babel-transpiler@5.7.4
│     └── workerpool@2.3.0  deduped
├─┬ ember-cli-babel@6.18.0
│ └─┬ broccoli-babel-transpiler@6.5.0
│   └── workerpool@2.3.0  deduped
├─┬ ember-cli-geo@4.0.0
│ └─┬ ember-cli-babel@5.2.8
│   └─┬ broccoli-babel-transpiler@5.7.4
│     └── workerpool@2.3.0  deduped
├─┬ ember-cli-moment-shim@2.0.0
│ └─┬ ember-cli-babel@5.2.8
│   └─┬ broccoli-babel-transpiler@5.7.4
│     └── workerpool@2.3.0  deduped
├─┬ ember-cli-test-loader@1.1.1
│ └─┬ ember-cli-babel@5.2.8
│   └─┬ broccoli-babel-transpiler@5.7.4
│     └── workerpool@2.3.0  deduped
├─┬ ember-cli-uglify@2.1.0
│ └─┬ broccoli-uglify-sourcemap@2.1.1
│   └── workerpool@2.3.0  deduped
├─┬ ember-cookies@0.4.0
│ └─┬ ember-cli-babel@7.7.3
│   └─┬ broccoli-babel-transpiler@7.2.0
│     └── workerpool@3.1.2 
├─┬ ember-data-copyable@1.0.0
│ ├─┬ ember-cli-babel@7.7.3
│ │ └─┬ broccoli-babel-transpiler@7.2.0
│ │   └── workerpool@3.1.2 
│ └─┬ ember-concurrency@0.8.27
│   └─┬ ember-cli-babel@6.18.0
│     └─┬ broccoli-babel-transpiler@6.5.1
│       └── workerpool@2.3.3 
├─┬ ember-date-components@2.0.4
│ ├─┬ ember-basic-dropdown@1.1.1
│ │ └─┬ ember-cli-babel@7.2.0
│ │   └─┬ broccoli-babel-transpiler@7.1.1
│ │     └── workerpool@2.3.3 
│ └─┬ ember-cli-babel@7.2.0
│   └─┬ broccoli-babel-transpiler@7.1.1
│     └── workerpool@2.3.3 
├─┬ ember-g-map@0.0.25
│ └─┬ ember-cli-babel@5.2.8
│   └─┬ broccoli-babel-transpiler@5.7.4
│     └── workerpool@2.3.0  deduped
├─┬ ember-infinity@1.2.6
│ └─┬ ember-cli-babel@7.1.4
│   └─┬ broccoli-babel-transpiler@7.2.0
│     └── workerpool@3.1.2 
├─┬ ember-power-select-with-create@0.6.0
│ └─┬ ember-power-select@2.0.8
│   └─┬ ember-cli-babel@6.17.2
│     └─┬ broccoli-babel-transpiler@6.5.0
│       └── workerpool@2.3.0  deduped
├─┬ ember-uploader@1.2.1
│ └─┬ ember-cli-babel@5.2.8
│   └─┬ broccoli-babel-transpiler@5.7.4
│     └── workerpool@2.3.0  deduped
└─┬ ui-ember-slider@0.5.0
  └─┬ ember-cli-babel@5.2.8
    └─┬ broccoli-babel-transpiler@5.7.4
      └── workerpool@2.3.0  deduped

Additionally, this is what I added to my config.yml file (the JOBS line):

docker:
      - image: circleci/build-image:ubuntu-14.04-XXL-upstart-1189-5614f37
        command: /sbin/init
        environment:
          JOBS: 1 # https://github.com/emberjs/ember.js/issues/15641