search

broccolijs / broccoli-persistent-filter

MIT License
12 stars 33 forks source link

Port to TypeScript #190

Closed chriseppstein closed 4 years ago

chriseppstein commented 4 years ago

Based on https://github.com/stefanpenner/template-ts

I've done this port on top of @SparshithNR's work to make use of the fs-merger. There's a followup to this PR in #191 that makes the dependency tracker work with the fs-merger. I've submitted these as separate PRs so we can keep the conversations distinct.

chriseppstein commented 4 years ago

@stefanpenner

  1. I pushed the change to convert broccoli-node-api to a dev dep.
  2. The tests are not skipped anymore in #191. We shouldn't release this PR without also landing that one.
  3. We also need @SparshithNR to review #191.
chriseppstein commented 4 years ago

@stefanpenner I've addressed all your feedback.

chriseppstein commented 4 years ago

This landed as part of #191