I'm writing a subclass based on the broccoli-persistent-filter in TypeScript, by now, calling super(node, options) in the constructor will cause an unfixable type error:
IMO, the dependencyInvalidation, and the concurrency options should not be required because the base class will set a default value for both of them when calling the super(node, option).
Shall we mark these two options as optional as well?
https://github.com/broccolijs/broccoli-persistent-filter/blob/8e939164bcb95bcbf99b1fcd72dd457dc6e0542f/index.ts#L134-L135
I'm writing a subclass based on the
broccoli-persistent-filter
in TypeScript, by now, callingsuper(node, options)
in theconstructor
will cause an unfixable type error:IMO, the
dependencyInvalidation
, and theconcurrency
options should not be required because the base class will set a default value for both of them when calling thesuper(node, option)
.Currently, I'm using a workaround below: