side effect free

[stefanpenner]

• [x] make work

• [x] tests

• [ ] docs/readme

• [ ] play with more real plugins (confirm API)

  • [ ] funnel https://github.com/broccolijs/broccoli-funnel/pull/96
  • [ ] broccoli-persistent-filter https://github.com/stefanpenner/broccoli-persistent-filter/pull/117
  • [ ] concat https://github.com/broccolijs/broccoli-concat/pull/114

• Future

  • [ ] merge https://github.com/broccolijs/broccoli-merge-trees/pull/60

TODO:

• [ ] broccolijs/broccoli
  • [ ] upgrade all string inputTrees to WatchedDir
  • [ ] watcheddirs need to be upgraded to side-affect freeness.
  • [ ] connect the WatcherAdapter and the list of known WatchedDirs

[vlascik]

So what happened to this PR, are there any plans to finish it?

[rwjblue]

Yes, we definitely still plan to circle back and land this (and related PRs). The issue that we identified after doing all of this initial work was that there was still too much volatility for this to really make a difference. Specifically, all "link roots" style broccoli-funnel instances (super super common) must be treated as volatile (since we cannot know if something inside the symlinked root changed). The solution to that issue is to be "watcher aware" (so that we can know through the symlink if a given raw source root has changed).

[thoov]

Closing in favor of: https://github.com/broccolijs/broccoli/pull/396