search

broccolijs / broccoli-plugin

Base class for Broccoli plugins
MIT License
25 stars 25 forks source link

Prevent arrays from masquerading as a node. #25

Closed rwjblue closed 6 years ago

rwjblue commented 6 years ago

The prior validation logic mishandled Array.isArray (because typeof [] returns "object"). This corrects that gap...

Closes https://github.com/broccolijs/broccoli-merge-trees/issues/63.

krisselden commented 6 years ago

typeof node.broccoliGetInfo === ‘function’

rwjblue commented 6 years ago

OK, updated, @krisselden mind reviewing again?