Closed poplevente closed 6 years ago
Yes, we are getting the same coming from the mergeTrees() call on Ember v2.5
A recent update to this library 3f9a42bd61a82fd86c03bbea6cb7ec8d81311e24 has caused function isPossibleNode(node)
to come back false. The object causing the error:
node:{
inputTree: Funnel {,
_name: 'Funnel',
_annotation: 'Funnel: Filtered App',
_baseConstructorCalled: true,
_inputNodes: [Array],
_persistentOutput: true,
_needsCache: false,
_includeFileCache: {},
_destinationPathCache: {},
_currentTree: [FSTree],
_isRebuild: false,
exclude: [Array],
annotation: 'Funnel: Filtered App',
destDir: '/',
count: 0,
_matchedWalk: true,
_instantiatedStack:
'at new Funnel (
node_modules/ember-cli/node_modules/broccoli-funnel/index.js:104:30)\n
at EmberApp._filterAppTree (//node_modules/ember-cli/lib/broccoli/ember-app.js:648:31)\n
at EmberApp._processedAppTree (//node_modules/ember-cli/lib/broccoli/ember-app.js:762:54)\n
at EmberApp.appAndDependencies (//node_modules/ember-cli/lib/broccoli/ember-app.js:1036:10)\n
at EmberApp.javascript (//node_modules/ember-cli/lib/broccoli/ember-app.js:1159:34)\n
at EmberApp.toArray (//node_modules/ember-cli/lib/broccoli/ember-app.js:1564:10)\n
at EmberApp.toTree (//node_modules/ember-cli/lib/broccoli/ember-app.js:1586:30)\n
at module.exports (//ember-cli-build.js:45:28)\n
at Class.setupBroccoliBuilder (//node_modules/ember-cli/lib/models/builder.js:55:19)\n
at Class.init (//node_modules/ember-cli/lib/models/builder.js:89:10)'
_buildStart: undefined
},
rebuild: [Function: rebuild]
}
}
an ugly fix is to manually go back to the previous version of this plugin, but this required changes within our automatic build, etc. would be nice to correct in a short time ...
This seems effectively the same as https://github.com/broccolijs/broccoli-merge-trees/issues/65, can you confirm? And also confirm that that solution fixed things for you?
The issue was solved for me thank you.
Thank you for confirming (and sorry for the problems), I'm going to close for now though I'm happy to reopen if there are still other issues...
i still get an error, this time the inputNodes issues is gone, but i get an Invalid tree found. the fix is the same if i revert the broccoli-plugin to version 1.3.0, then it's okay.
Hi Guys,
since the last update we get BroccoliMergeTrees (TreeMerger (lint app)): Expected Broccoli node, got [object Object] for inputNodes[1]
not sure if it's related to the last update or not, did anyone encouter the same? any reason this might happen?