broccolijs / broccoli

Browser compilation library – an asset pipeline for applications that run in the browser
https://broccoli.build
MIT License
3.33k stars 216 forks source link

POC [Fixes #311] fix cleanup #312

Closed stefanpenner closed 6 years ago

stefanpenner commented 7 years ago
joliss commented 7 years ago

I actually wonder if it's conceptually necessary to tie the cancellation thing to the cleanup function. In other words, I don't think there's any reason why in general we couldn't start a fresh build after canceling the current build, instead of cleaning up immediately. We shouldn't end up in any "wedged" state that would stop us from doing so.

So if we do that, the Ctrl+C handler would do something like:

cancelCurrentBuild()
then wait for currentBuild
then cleanup
stefanpenner commented 7 years ago

@joliss i'll update this to be more like what I ended-up with on 0.18.x. There are some nuanced differences, that have not made it to this PR yet.


Some thoughts:

stefanpenner commented 6 years ago

replaced by: https://github.com/broccolijs/broccoli/pull/350