search

broccolijs / broccoli

Browser compilation library – an asset pipeline for applications that run in the browser
https://broccoli.build
MIT License
3.33k stars 216 forks source link

quick fix for cli build command #338

Closed chrmod closed 6 years ago

chrmod commented 6 years ago

current master throws: TypeError: builder.cleanup is not a function

chrmod commented 6 years ago

@rwjblue make sense. I'm on it

stefanpenner commented 6 years ago

Apparently, I don't understand the TDZ.

chrmod commented 6 years ago

@rwjblue @stefanpenner those tests were not too easy to write and I'm not 100% sure if those are what we want from them. Please review.

chrmod commented 6 years ago

@stefanpenner can you please replay appveyor. Wonder if it is random fail or something is different on node 9.

stefanpenner commented 6 years ago

@stefanpenner can you please replay appveyor. Wonder if it is random fail or something is different on node 9.

Unfortunately I cannot, appveyor does not believe I am an owner of this repo.... for unknown reasons.

rwjblue commented 6 years ago

Same here. 🤔

stefanpenner commented 6 years ago

I'll merge, and keep an eye on master.

@chrmod much appreciated!!