search

broccolijs / broccoli

Browser compilation library – an asset pipeline for applications that run in the browser
https://broccoli.build
MIT License
3.33k stars 217 forks source link

Implement cleanup promise #365

Closed oligriffiths closed 6 years ago

oligriffiths commented 6 years ago

This PR makes cleanup() return a promise, as is consistent with the broccoli-builder api https://github.com/ember-cli/broccoli-builder/blob/d3add6436f8e1c29f4532482bf7fda8dc10b0017/lib/builder.js#L210-L219 and is used in ember-cli here: https://github.com/ember-cli/ember-cli/blob/689bdbfee75ef92a33a86466669062bfb7507531/lib/models/builder.js#L193

This, along with https://github.com/broccolijs/broccoli/pull/363 should allow us to start iterating on broccoli master, within ember-cli https://github.com/ember-cli/ember-cli/pull/7798

oligriffiths commented 6 years ago

Closing this in favour of https://github.com/ember-cli/ember-cli/pull/7798/commits/647311f639c461bb5d8bcaf466d31c8cf2a070b4