search

broccolijs / broccoli

Browser compilation library – an asset pipeline for applications that run in the browser
https://broccoli.build
MIT License
3.33k stars 217 forks source link

Fixing ember-cli/ember-cli#8677 #409

Closed thoov closed 5 years ago

thoov commented 5 years ago

Bringing to parity with broccoli-sane-watcher the filePath property in the change event and the additional console logging from a sane event.

cc: @oligriffiths / @stefanpenner

oligriffiths commented 5 years ago

We should probably do this change file tracking also https://github.com/ember-cli/broccoli-sane-watcher/blob/48860/index.js#L103-L113

stefanpenner commented 5 years ago

I'm good with this once @oligriffiths's good with it, specifically this comment: https://github.com/broccolijs/broccoli/pull/409#discussion_r290776322

lifeart commented 5 years ago

Do we need absolute path?

stefanpenner commented 5 years ago

Do we need absolute path?

Good point, I'm largely indifferent. My guess is that absolute path will help pinpoint exactly what changed in a large app. That being said, if it breaks something we should leave it as is.

lifeart commented 5 years ago

all ok, double checked file Path - is absolute path (previously)

stefanpenner commented 5 years ago

released as v3.0.1 🎉